Prevent ZIP installs from clearing unrelated plugins and themes - #311
Merged
Conversation
adamziel
changed the title
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid plugin or theme ZIP created from the current directory may begin with
./. The old installers treated the first path segment as the target folder. That made the targetWP_PLUGIN_DIR/.orwp-content/themes/.and recursively cleared unrelated plugins or themes before WordPress selected the installation folder.This change leaves target selection, replacement, and installed-folder detection to
Plugin_UpgraderandTheme_Upgrader. Regression tests cover plugin and theme archives beginning with./and confirm that existing unrelated plugins and themes survive.Windows test cleanup now removes each copied WordPress site instead of retaining all copies until the job ends. Current hosted Windows runners otherwise exhaust the 15 GB temporary drive before the suite finishes.
Testing
vendor/bin/phpunit components/Blueprints/Tests/Unit/Steps(77 tests, 185 assertions)vendor/bin/phpcs -d memory_limit=1G components/Blueprints/Steps/class-installpluginstep.php components/Blueprints/Steps/class-installthemestep.php components/Blueprints/Tests/Unit/Steps/InstallPluginStepTest.php components/Blueprints/Tests/Unit/Steps/InstallThemeStepTest.php components/Blueprints/Tests/Unit/Steps/StepTestCase.phpCloses #310